Add support for dynamic callback URL in Google sign-in flow#481
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for a dynamic callback URL in the Google sign-in flow.
- Dynamically builds the callback URL from the provided redirect path and the current window location.
- Passes the generated URL string to the auth client’s social sign-in method.
Comment on lines
+26
to
+30
| const callbackURL = new URL(redirectTo, window.location.origin); | ||
|
|
||
| await authClient.signIn.social({ | ||
| provider: "google", | ||
| callbackURL: callbackURL.toString(), |
There was a problem hiding this comment.
[nitpick] Consider inlining the URL conversion if the variable is only used once (e.g., directly passing new URL(redirectTo, window.location.origin).toString() to authClient.signIn.social), or add a clarifying comment if keeping the variable improves readability.
Suggested change
| const callbackURL = new URL(redirectTo, window.location.origin); | |
| await authClient.signIn.social({ | |
| provider: "google", | |
| callbackURL: callbackURL.toString(), | |
| await authClient.signIn.social({ | |
| provider: "google", | |
| callbackURL: new URL(redirectTo, window.location.origin).toString(), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Visual Demo (For contributors especially)
A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).
Video Demo (if applicable):
Image Demo (if applicable):
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist